git.openwrt.org Git - openwrt/openwrt.git/blob

   1 From e17813968b08b1b09bf80699223dea48851cbd07 Mon Sep 17 00:00:00 2001
   2 From: =?UTF-8?q?=C3=81lvaro=20Fern=C3=A1ndez=20Rojas?= <noltari@gmail.com>
   3 Date: Sat, 14 Jun 2025 09:59:56 +0200
   4 Subject: [PATCH] net: dsa: b53: prevent BRCM_HDR access on older devices
   5 MIME-Version: 1.0
   6 Content-Type: text/plain; charset=UTF-8
   7 Content-Transfer-Encoding: 8bit
   8
   9 Older switches don't implement BRCM_HDR register so we should avoid
  10 reading or writing it.
  11
  12 Reviewed-by: Florian Fainelli <florian.fainelli@broadcom.com>
  13 Signed-off-by: Álvaro Fernández Rojas <noltari@gmail.com>
  14 Link: https://patch.msgid.link/20250614080000.1884236-11-noltari@gmail.com
  15 Signed-off-by: Jakub Kicinski <kuba@kernel.org>
  16 ---
  17  drivers/net/dsa/b53/b53_common.c | 5 +++++
  18  1 file changed, 5 insertions(+)
  19
  20 --- a/drivers/net/dsa/b53/b53_common.c
  21 +++ b/drivers/net/dsa/b53/b53_common.c
  22 @@ -747,6 +747,11 @@ void b53_brcm_hdr_setup(struct dsa_switc
  23                 hdr_ctl |= GC_FRM_MGMT_PORT_M;
  24         b53_write8(dev, B53_MGMT_PAGE, B53_GLOBAL_CONFIG, hdr_ctl);
  25
  26 +       /* B53_BRCM_HDR not present on devices with legacy tags */
  27 +       if (dev->tag_protocol == DSA_TAG_PROTO_BRCM_LEGACY ||
  28 +           dev->tag_protocol == DSA_TAG_PROTO_BRCM_LEGACY_FCS)
  29 +               return;
  30 +
  31         /* Enable Broadcom tags for IMP port */
  32         b53_read8(dev, B53_MGMT_PAGE, B53_BRCM_HDR, &hdr_ctl);
  33         if (tag_en)